Vision cloud client snippets #751
Conversation
googlebot
added
the
cla: yes
vision/cloud-client/snippets.py
Outdated
| import io | ||
| import os | ||
|
|
||
| # Imports the Google Cloud client library |
There was a problem hiding this comment.
This comment isn't necessary. :)
There was a problem hiding this comment.
Removed extraneous comments.
vision/cloud-client/snippets.py
Outdated
| # Loads the image into memory | ||
| with io.open(path, 'rb') as image_file: | ||
| content = image_file.read() | ||
| image = vision_client.image( |
There was a problem hiding this comment.
This line doesn't need to be within the with context.
vision/cloud-client/snippets.py
Outdated
| image = vision_client.image( | ||
| content=content) | ||
|
|
||
| # Performs face detection on the image file |
There was a problem hiding this comment.
This comment is obvious in context.
(Typically focus comments on why over what, especially if this isn't a quickstart)
There was a problem hiding this comment.
Removed extraneous comments.
vision/cloud-client/snippets.py
Outdated
| # Performs face detection on the image file | ||
| faces = image.detect_faces() | ||
|
|
||
| print 'Faces:' |
There was a problem hiding this comment.
use print-as-a-function (print(...)) so that this work with Python 3. :)
vision/cloud-client/snippets.py
Outdated
|
|
||
| print 'Faces:' | ||
| for face in faces: | ||
| print 'anger', face.emotions.anger |
There was a problem hiding this comment.
use .format over multiple args to print.
vision/cloud-client/snippets.py
Outdated
|
|
||
|
|
||
| def detect_faces_gcs(path): |
There was a problem hiding this comment.
avoid initialisms unless its the primary focus of the sample, prefer detect_faces_cloud_storage.
vision/cloud-client/snippets.py
Outdated
| def detect_faces_gcs(path): | ||
| # Instantiates a client | ||
| vision_client = vision.Client() | ||
| image = vision_client.image(source_uri=path) |
There was a problem hiding this comment.
Is this argument a path or is it a uri?
There was a problem hiding this comment.
Changed to URI where appropriate.
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """This application demonstrates how to perform basic operations with the |
There was a problem hiding this comment.
nit: blank newline between license and docstring.
vision/cloud-client/detect.py
Outdated
| anger=face.emotions.anger, | ||
| joy=face.emotions.joy, | ||
| surprise=face.emotions.surprise) | ||
| print('') |
There was a problem hiding this comment.
Is this strictly necessary or do you just like a blank newline at the end of the program output?
There was a problem hiding this comment.
Entirely aesthetic, I'm happy to remove the empty print statements.
vision/cloud-client/detect.py
Outdated
| print('Safe search:') | ||
| for safe in safe_searches: | ||
| print('adult: {adult}\nmedical: {medical}\nspoofed: {spoofed}\n' + | ||
| 'violence: {violence}\n').format(adult=safe.adult, |
There was a problem hiding this comment.
Oh god, my eyes! No hanging indents, please:
print('oh god why did I make this string so long what is wrong with me.'.format(
arg1=something, arg2=something, ...)
vision/cloud-client/detect.py
Outdated
| safe_searches = image.detect_safe_search() | ||
| print('Safe search:') | ||
| for safe in safe_searches: | ||
| print('adult: {adult}\nmedical: {medical}\nspoofed: {spoofed}\n' + |
There was a problem hiding this comment.
If you need newlines in your print, either make it separate print statements or use heredoc.
There was a problem hiding this comment.
Done. I just removed the extraneous prints.
|
@dpebot merge when travis passes, pretty please. |
|
Okay! I'll merge when all statuses are green. |
dpebot
added
the
automerge
|
@gguuss oh no, the linter thinks your main is too complex! Might need to bump it the config in https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/nox.py#L141 |
Adds snippet code for all 7 vision scenarios (GCS and local file) with the intention of longer-term sourcing all the snippets to the vision docs.